Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[SecurityBundle] Remove the require_previous_session config option #51333

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Aug 9, 2023

Q A
Branch? 7.0
Bug fix? no
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

To merge after #51332 is merged on 6.4 which deprecate config option. This PR remove last usage of option

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.0" but it seems your PR description refers to branch "7.0 for features / 5.4, or 6.3 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

Copy link
Member

@wouterj wouterj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an entry to UPGRADE-7.0.md and the bundle's CHANGELOG.

fabpot added a commit that referenced this pull request Aug 11, 2023
…on` config option (alamirault)

This PR was squashed before being merged into the 6.4 branch.

Discussion
----------

[SecurityBundle] Deprecate the `require_previous_session` config option

| Q             | A
| ------------- | ---
| Branch?       | 6.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | yes <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #51318  <!-- prefix each issue number with "Fix #", no need to create an issue if none exists, explain below instead -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

This PR deprecate the `require_previous_session` config option

Remove is done in #51333 on 7.0

Commits
-------

f92b0fc [SecurityBundle] Deprecate the `require_previous_session` config option
@fabpot
Copy link
Member

fabpot commented Aug 11, 2023

Thank you @alamirault.

@fabpot fabpot force-pushed the feature/51318-deprecate-require-previous-session-7 branch from 1d53ccc to 6372df4 Compare August 11, 2023 08:14
@fabpot fabpot merged commit 7784ee1 into symfony:7.0 Aug 11, 2023
@alamirault alamirault deleted the feature/51318-deprecate-require-previous-session-7 branch August 11, 2023 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.