[Ldap] Allow to use ldap in a chain provider #51231
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c63cdc0 to
ee6ec00
Compare
c1a964d to
731dcd3
Compare
OskarStark
reviewed
Aug 4, 2023
OskarStark
reviewed
Aug 4, 2023
fa50a1e to
cbe2c95
Compare
vtsykun
reviewed
Aug 4, 2023
src/Symfony/Component/Ldap/Security/CheckLdapCredentialsListener.php
Outdated
Show resolved
Hide resolved
2120810 to
726db70
Compare
726db70 to
8dbeb60
Compare
|
This looks like a feature |
|
@chalasr I don't know if it's really a feature, it worked with the Guard system and the feature has seamlessly disappeared with the replacement of Guard by Authenticators (and there was no announcement that the feature was not supported with Authenticators). |
stof
reviewed
Apr 2, 2025
| @@ -171,6 +196,9 @@ public static function queryForDnProvider(): iterable | ||
| yield ['{user_identifier}', '{user_identifier}_test']; | ||
| } | ||
|
|
||
| /** | ||
| * @group legacy |
There was a problem hiding this comment.
why is this becoming a legacy tests ? Why would we remove this test when removing deprecated features related to this PR ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR allows to fix that the
LdapUserProviderthat not work properly when used in theChainProvider.This fix relies on two ideas:
LdapBadgeis not a badge that must be resolved, it's only used to carry Ldap dataCheckLdapCredentialsListenerto check against the ldap directory the password for a non-ldap user using a new#[WithLdapPassword]attribute