[Templating] deprecate the component #51144
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm not sure how to suppress the deprecations. I've added |
|
The component is still downloaded 30K/day. Not on legacy projects since there is 6.4K daily installs for the v6. |
|
I think a good chunk of the downloads are transient. For instance, knplabs/knp-time-bundle requires it and has ~4k daily downloads. |
This was referenced Jul 28, 2023
derrabus
reviewed
Jul 28, 2023
derrabus
reviewed
Jul 28, 2023
|
👍 for the proposal. Deprecating it will still mean maintaining it for the duration of the LTS, so 3 more years. |
|
Any corresponding config tree in frameworkbundle that should also be deprecated? |
Didn't this happen in #32267 already? |
derrabus
reviewed
Jul 28, 2023
fabpot
approved these changes
Jul 30, 2023
GromNaN
approved these changes
Jul 30, 2023
derrabus
approved these changes
Jul 30, 2023
|
Thank you @kbond. |
afd830d to
2a07431
Compare
This was referenced Aug 3, 2023
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's time to deprecate/remove this component.