[DependencyInjection] Add test for issue #49591 #51123
Conversation
|
Hey! Oh no, it looks like you have made this PR towards a branch that is not maintained anymore. :/ Cheers! Carsonbot |
dc86eb4 to
eae6341
Compare
| $dumper = new PhpDumper($containerBuilder); | ||
| $dump = $dumper->dump(['class' => 'Symfony_DI_PhpDumper_Issues49591']); | ||
|
|
||
| self::assertStringEqualsFile(__DIR__.'/Fixtures/php/services_issues49591.php', $dump); |
There was a problem hiding this comment.
This is the assertion that fails currently. But as far as I understood the issue, the actual issue is reproduced by the following assertion. Do we need this fixture anyway? Doesn't comparing the dump to the fixture only make the test brittle?
There was a problem hiding this comment.
No, it's really not needed, I only added it so that the dumped container can be seen as it might help to understand the issue.
There was a problem hiding this comment.
I've removed the assertion & updated the dump for version 6.3 (I originally generated it with 6.2).
eae6341 to
907ed45
Compare
|
It looks like a cyclic dependency. Perhaps the right solution would be throw a
|
A simple test case to illustrate the problem.