Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Messenger] Deprecate StopWorkerOnSignalsListener #50997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 19, 2023
Merged

[Messenger] Deprecate StopWorkerOnSignalsListener #50997

merged 1 commit into from
Jul 19, 2023

Conversation

HypeMC
Copy link
Member

@HypeMC HypeMC commented Jul 16, 2023

Q A
Branch? 6.4
Bug fix? no
New feature? no
Deprecations? yes
Tickets -
License MIT
Doc PR -

Followup to #50787.

@carsonbot carsonbot added this to the 6.4 milestone Jul 16, 2023
@HypeMC HypeMC mentioned this pull request Jul 16, 2023
Merged
@xabbuh
Copy link
Member

xabbuh commented Jul 17, 2023

StopWorkerOnSigtermSignalListener should be updated as well. It would currently reference the now deprecated class.

@HypeMC HypeMC force-pushed the deprecate-stop-worker-on-signals-listener branch 3 times, most recently from 9fad606 to fbcda78 Compare July 17, 2023 07:51
@HypeMC
Copy link
Member Author

HypeMC commented Jul 17, 2023

@xabbuh Done. Not sure about the pslam error, it shouldn't be a problem.

@HypeMC HypeMC force-pushed the deprecate-stop-worker-on-signals-listener branch from fbcda78 to 0b62ce8 Compare July 19, 2023 19:33
@nicolas-grekas
Copy link
Member

Thank you @HypeMC.

@nicolas-grekas nicolas-grekas merged commit 40d61eb into symfony:6.4 Jul 19, 2023
@nicolas-grekas nicolas-grekas mentioned this pull request Jul 19, 2023
Closed
@HypeMC HypeMC deleted the deprecate-stop-worker-on-signals-listener branch July 19, 2023 19:46
@nicolas-grekas
Copy link
Member

PR welcome on 7.0 for the cleanup 🙏

@xabbuh
Copy link
Member

xabbuh commented Jul 20, 2023 •
edited
Loading

Looking at what would need to be cleaned up in 7.0 I stumbled upon the stop_worker_on_signals messenger config option which until now modifies the StopWorkerOnSignalsListener constructor arguments. Shouldn't this part of the FrameworkExtension have been updated in this PR too?

@HypeMC
Copy link
Member Author

HypeMC commented Jul 21, 2023 •
edited
Loading

@xabbuh No, the stop_worker_on_signals config will be used in certain commands, see #50787.

@HypeMC HypeMC mentioned this pull request Jul 21, 2023
Merged
nicolas-grekas added a commit that referenced this pull request Jul 26, 2023
@nicolas-grekas
minor #51064 [Messenger] Remove deprecated `StopWorkerOnSignalsListen…
67a869f 
…er` (HypeMC)

This PR was merged into the 7.0 branch.

Discussion
----------

[Messenger] Remove deprecated `StopWorkerOnSignalsListener`

| Q             | A
| ------------- | ---
| Branch?       | 7.0
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Followup to #50997.

Commits
-------

4366044 [Messenger] Remove deprecated `StopWorkerOnSignalsListener`
This was referenced Oct 21, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

Assignees
No one assigned
Labels
Deprecation Messenger Status: Needs Review
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.
4 participants
@HypeMC @xabbuh @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.