[7.0] Remove remaining deprecated code paths #50873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
commented
Jul 4, 2023
| @@ -48,7 +48,7 @@ protected function getDefaultFormatter() | ||
| /** | ||
| * @author Grégoire Pineau <lyrixx@lyrixx.info> | ||
| * | ||
| * @internal since Symfony 6.1 | ||
| * @internal | ||
| */ | ||
| trait ServerLogHandlerTrait |
There was a problem hiding this comment.
Yes that would allow some conditional code mess to be cleaned up which sounds great
There was a problem hiding this comment.
@lyrixx up for a PR doing so?
nicolas-grekas
commented
Jul 4, 2023
| @@ -22,7 +22,7 @@ | ||
| return static function (ContainerConfigurator $container) { | ||
| $container->services() | ||
| ->set('annotations.reader', AnnotationReader::class) | ||
| ->call('addGlobalIgnoredName', ['required']) // @deprecated since Symfony 6.3 | ||
| ->call('addGlobalIgnoredName', ['required']) |
There was a problem hiding this comment.
keeping this as is so that ppl can still use the annotation without being bothered
wouterj
reviewed
Jul 4, 2023
|
You forgot to update the CHANGELOG of the workflow component (a least this one) |
f07fb6f to
048170f
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 4, 2023
…-grekas) This PR was merged into the 6.4 branch. Discussion ---------- [6.4] Fix remainings from previous deprecations | Q | A | ------------- | --- | Branch? | 6.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Found while working on #50873 Commits ------- 2d59b2f [6.4] Fix remainings from previous deprecations
048170f to
3306b31
Compare
3306b31 to
8b687f6
Compare
8b687f6 to
5e4a1c6
Compare
nicolas-grekas
added a commit
that referenced
this pull request
Jul 5, 2023
…scriptors (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [Messenger] Fix passing options set via tags to handler descriptors | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - Spotted while working on #50873 Commits ------- 2a6f72b [Messenger] Fix passing options set via tags to handler descriptors
5e4a1c6 to
955285f
Compare
955285f to
e96702a
Compare
e96702a to
6baa3d2
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Form
DateTimeorDateTimeImmutablemodel data with a different timezone than configured with themodel_timezoneoption inDateType,DateTimeType, andTimeTypeFrameworkBundle
http_method_overrideconfig option default tofalseAbstractController::renderForm(), userender()insteadSymfony\Component\Serializer\Normalizer\ObjectNormalizerandSymfony\Component\Serializer\Normalizer\PropertyNormalizerautowiring aliases, type-hint againstSymfony\Component\Serializer\Normalizer\NormalizerInterfaceor implementNormalizerAwareInterfaceinsteadHttp\Client\HttpClientservice, usePsr\Http\Client\ClientInterfaceinsteadMessenger
MessageHandlerInterfaceandMessageSubscriberInterface, use#[AsMessageHandler]insteadStopWorkerOnSigtermSignalListenerin favor ofStopWorkerOnSignalsListenerand make it configurable with SIGINT andSymfony\Component\Messenger\Transport\InMemoryTransportandSymfony\Component\Messenger\Transport\InMemoryTransportFactoryin favor ofSymfony\Component\Messenger\Transport\InMemory\InMemoryTransportandSymfony\Component\Messenger\Transport\InMemory\InMemoryTransportFactoryTranslation
PhpStringTokenParserPhpExtractorin favor ofPhpAstExtractorTwigBundle
twig.autoescape, usetwig.autoescape_service[_method]insteadTwig_Environmentautowiring alias, useTwig\EnvironmentinsteadYaml
!php/const:tag, use!php/constinstead (without the colon)