[DependencyInjection] Skip scanning scalar values in compiler passes when not needed #50743
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f49b6a to
cd94d75
Compare
src/Symfony/Component/DependencyInjection/ParameterBag/ParameterBag.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/AbstractRecursivePass.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/DependencyInjection/Compiler/ResolveParameterPlaceHoldersPass.php
Outdated
Show resolved
Hide resolved
cd94d75 to
2e54672
Compare
bastnic
commented
Jun 22, 2023
| @@ -77,6 +78,9 @@ protected function processValue(mixed $value, bool $isRoot = false) | ||
| { | ||
| if (\is_array($value)) { | ||
| foreach ($value as $k => $v) { | ||
| if (\is_scalar($v ?? true) && $this->skipScalars) { |
There was a problem hiding this comment.
the point is that only ResolveParameterPlaceHoldersPass should NOT skip that
There was a problem hiding this comment.
And ResolveEnvPlaceholdersPass also :)
f131904 to
470bc1f
Compare
470bc1f to
485574a
Compare
nicolas-grekas
approved these changes
Jun 22, 2023
b50509b to
5e2e97f
Compare
|
Are you profiling the same app guys 😃 ? |
|
@javaDeveloperKid guilty. I used the famous github function "ask a core contrib". Costs me a lot of coffee and beers. |
maxbeckers
approved these changes
Jun 23, 2023
5e2e97f to
9a4fa3f
Compare
9a4fa3f to
f9f2baa
Compare
|
Thank you @bastnic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While profiling an app with ~2600 auto-discovered services, I figured out that we have a way bigger calls to string process that logic would expect.