Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[FrameworkBundle] Ignore missing directories in about command #50665

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 21, 2023
Merged

[FrameworkBundle] Ignore missing directories in about command #50665

merged 1 commit into from
Jun 21, 2023

Conversation

ro0NL
Copy link
Contributor

@ro0NL ro0NL commented Jun 15, 2023

Q A
Branch? 5.4
Bug fix? yes IMHO
New feature? no
Deprecations? no
Tickets Fix #...
License MIT
Doc PR symfony/symfony-docs#...

This fixes our CI when var/log is missing.

Before:

In AboutCommand.php line 105:
                                                                                                              
  [UnexpectedValueException]                                                                                  
  RecursiveDirectoryIterator::__construct(/app/var/log): Failed to open directory: No such file or directory

After:

  Cache directory      ./var/cache/prod (939 KiB)  
  Build directory      ./var/cache/prod (939 KiB)  
  Log directory        ./var/log (n/a)

@carsonbot carsonbot added this to the 5.4 milestone Jun 15, 2023
ro0NL
ro0NL commented Jun 15, 2023
View reviewed changes
src/Symfony/Bundle/FrameworkBundle/Command/AboutCommand.php
@@ -109,6 +109,10 @@ private static function formatFileSize(string $path): string
if (is_file($path)) {
$size = filesize($path) ?: 0;
} else {
if (!is_dir($path)) {
return 'n/a';
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the abstraction for "formatted file size" is any string, hence this looks appropriate to me

@fabpot
Copy link
Member

fabpot commented Jun 21, 2023

Thank you @ro0NL.

@fabpot fabpot merged commit 5c512f6 into symfony:5.4 Jun 21, 2023
@ro0NL ro0NL deleted the patch-1 branch June 21, 2023 06:30
This was referenced Jun 26, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
4 participants
@ro0NL @fabpot @nicolas-grekas @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.