Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Messenger] Use immutable dates in the storage when using Doctrine #50289

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 10, 2023
Merged

[Messenger] Use immutable dates in the storage when using Doctrine #50289

merged 1 commit into from
May 10, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.3
Bug fix? no
New feature? no
Deprecations? no
Tickets Part of #47580
License MIT
Doc PR -

We already started using DateTimeImmutable in that class but we missed these updates.

@carsonbot carsonbot added this to the 6.3 milestone May 10, 2023
stof
stof approved these changes May 10, 2023
View reviewed changes
Copy link
Member

@stof stof left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't matter much in practice (when converting from PHP to the database, both types accept any DateTimeInterface, the difference is only when converting in the other direction, which is not used in this class). But this is indeed good for consistency.

@nicolas-grekas nicolas-grekas merged commit fb234d5 into symfony:6.3 May 10, 2023
@nicolas-grekas nicolas-grekas deleted the msg-immut branch May 10, 2023 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Messenger Status: Reviewed
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
3 participants
@nicolas-grekas @stof @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.