[Messenger] Add a way to redispatch a message #49734
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolas-grekas
approved these changes
Mar 20, 2023
|
I really like this feature, however one question:
So why is As it suggests I should not use that in my app code. |
fabpot
added a commit
that referenced
this pull request
Jun 20, 2023
…ltzu) This PR was merged into the 6.3 branch. Discussion ---------- [Messenger] Don't mark `RedispatchMessage` as internal | Q | A | ------------- | --- | Branch? | 6.3 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT As discussed in #49734 (comment), `RedispatchMessage` is meant to be used in your project, hence it shouldn't be marked as internal (which makes IDEs suggest not to use it). Commits ------- 1209b81 Don't mark RedispatchMessage as internal
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was part of the Scheduler PR, but was removed as it was controversial.
Instead of having it by default in Scheduler, I've made it generic in Messenger.
If one wants to use it with Scheduler, they can use this: