[FrameworkBundle] Fix registration of the Scheduler component #49731
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
fabpot
commented
Mar 19, 2023
| Q | A |
|---|---|
| Branch? | 6.3 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | n/a |
| License | MIT |
| Doc PR | n/a |
fabpot
commented
Mar 19, 2023
| @@ -1614,7 +1614,7 @@ private function addSchedulerSection(ArrayNodeDefinition $rootNode, callable $en | ||
| ->children() | ||
| ->arrayNode('scheduler') | ||
| ->info('Scheduler configuration') | ||
| ->{$enableIfStandalone('symfony/scheduler', SchedulerTransportFactory::class)}() | ||
| ->{$enableIfStandalone('symfony/scheduler', Schedule::class)}() |
There was a problem hiding this comment.
We need to use a class that has no dependencies on other components.
Here, if we require Scheduler without Messenger, you will get a PHP error.
| if (!interface_exists(MessageBusInterface::class)) { | ||
| throw new LogicException('Scheduler support cannot be enabled as the Messenger component is not installed. Try running "composer require symfony/messenger".'); | ||
| } | ||
|
|
There was a problem hiding this comment.
Not needed as already done line 536.
xabbuh
approved these changes
Mar 19, 2023
fabpot
commented
Mar 19, 2023
| { | ||
| return $this->lock ?? new NoLock(); |
47a83de to
251ed12
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.