Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Scheduler] Fix some minor bugs #49716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 17, 2023
Merged

[Scheduler] Fix some minor bugs #49716

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions 3 src/Symfony/Component/Scheduler/Generator/MessageGenerator.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,6 +52,9 @@ public function getMessages(): \Generator

while (!$heap->isEmpty() && $heap->top()[0] <= $now) {
/** @var TriggerInterface $trigger */
/** @var int $index */
/** @var \DateTimeImmutable $time */
/** @var object $message */
[$time, $index, $trigger, $message] = $heap->extract();
$yield = true;

Expand Down
3 changes: 3 additions & 0 deletions 3 src/Symfony/Component/Scheduler/Generator/MessageGeneratorInterface.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,8 @@
*/
interface MessageGeneratorInterface
{
/**
* @return iterable<object>
*/
public function getMessages(): iterable;
}
9 changes: 7 additions & 2 deletions 9 src/Symfony/Component/Scheduler/RecurringMessage.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@

namespace Symfony\Component\Scheduler;

use Symfony\Component\Scheduler\Exception\InvalidArgumentException;
use Symfony\Component\Scheduler\Trigger\CronExpressionTrigger;
use Symfony\Component\Scheduler\Trigger\PeriodicalTrigger;
use Symfony\Component\Scheduler\Trigger\TriggerInterface;
Expand All @@ -31,9 +32,13 @@ private function __construct(
*
* @see https://php.net/datetime.formats.relative
*/
public static function every(string $frequency, object $message, \DateTimeImmutable $from = new \DateTimeImmutable(), ?\DateTimeImmutable $until = new \DateTimeImmutable('3000-01-01')): self
public static function every(string $frequency, object $message, \DateTimeImmutable $from = new \DateTimeImmutable(), \DateTimeImmutable $until = new \DateTimeImmutable('3000-01-01')): self
{
return new self(PeriodicalTrigger::create(\DateInterval::createFromDateString($frequency), $from, $until), $message);
if (false === $interval = \DateInterval::createFromDateString($frequency)) {
throw new InvalidArgumentException(sprintf('Frequency "%s" cannot be parsed.', $frequency));
}

return new self(PeriodicalTrigger::create($interval, $from, $until), $message);
}

public static function cron(string $expression, object $message): self
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.