Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Notifier] Add "retry" and "expire" options to Pushover bridge #49695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2023
Merged

[Notifier] Add "retry" and "expire" options to Pushover bridge #49695

merged 1 commit into from
Mar 17, 2023

Conversation

vlepeule
Copy link
Contributor

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Add "retry" and "expire" options to handle "Emergency Priority", according to Pushover API documentation :

To send an emergency-priority notification, the priority parameter must be set to 2 and the retry and expire parameters must be supplied.

@vlepeule vlepeule requested a review from OskarStark as a code owner March 15, 2023 22:34
@carsonbot carsonbot added this to the 6.3 milestone Mar 15, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@vlepeule vlepeule changed the title Add retry and expire options [Notifier] Add "retry" and "expire" options to Pushover bridge Mar 15, 2023
@nicolas-grekas
Copy link
Member

/cc @mocodo WDYT?

@mocodo
Copy link
Contributor

mocodo commented Mar 17, 2023

That's a nice addition, I totally missed those options when I did my PR.

Good catch @vlepeule

@nicolas-grekas
Copy link
Member

Thank you @vlepeule.

@nicolas-grekas nicolas-grekas merged commit c77b407 into symfony:6.3 Mar 17, 2023
@vlepeule vlepeule deleted the patch-1 branch March 30, 2023 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OskarStark OskarStark Awaiting requested review from OskarStark OskarStark is a code owner

Assignees
No one assigned
Labels
Bug Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.
4 participants
@vlepeule @carsonbot @nicolas-grekas @mocodo
Morty Proxy This is a proxified and sanitized view of the page, visit original site.