Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Mailer] Update Infobip API transport #49488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 22, 2023
Merged

[Mailer] Update Infobip API transport #49488

merged 1 commit into from
Feb 22, 2023

Conversation

ndousson
Copy link
Contributor

@ndousson ndousson commented Feb 22, 2023 •
edited
Loading

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

📍 Context

Infobip send an email to their customers that do not use the latest API release: V3

They inform that everything is backward compatible and can be easily upgraded without any changes.

🛠️ Changes

This PR change the version used from the V2 to the V3.

@carsonbot
Copy link

Hey!

To help keep things organized, we don't allow "Draft" pull requests. Could you please click the "ready for review" button or close this PR and open a new one when you are done?

Note that a pull request does not have to be "perfect" or "ready for merge" when you first open it. We just want it to be ready for a first review.

Cheers!

Carsonbot

@ndousson ndousson force-pushed the update_infobip_api_transport branch from 8e21fda to 0b1757a Compare February 22, 2023 09:57
@ndousson ndousson marked this pull request as ready for review February 22, 2023 09:58
@carsonbot carsonbot added this to the 6.2 milestone Feb 22, 2023
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.3 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title Update Infobip API transport [Mailer] Update Infobip API transport Feb 22, 2023
nicolas-grekas
nicolas-grekas reviewed Feb 22, 2023
View reviewed changes
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please split this PR in two?
One for 6.2, that just bump the number in the default endpoint. This will be a bugfix and doesn't need any change to the CHANGELOG file

Another one for 6.3 to propose the new attributes. Note that no other bridges support similar features and we've been super careful not to create bridges with too custom behaviors. This might be discussed on that new PR.

@ndousson
Copy link
Contributor Author

Thanks Nicolas for your feedback 🙏

I'll split this PR as you suggest.

I know that other bridges didn't work like Infobip but I hope we'll find a good way to be able to use reporting behavior 👍
We'll see in the PR for 6.3

@ndousson ndousson force-pushed the update_infobip_api_transport branch from 0b1757a to 8e73a82 Compare February 22, 2023 10:48
@ndousson ndousson force-pushed the update_infobip_api_transport branch from 8e73a82 to 18eb6e8 Compare February 22, 2023 10:49
@nicolas-grekas
Copy link
Member

Thank you @ndousson.

@nicolas-grekas nicolas-grekas merged commit 6bd3af0 into symfony:6.2 Feb 22, 2023
@ndousson ndousson deleted the update_infobip_api_transport branch February 22, 2023 16:26
@fabpot fabpot mentioned this pull request Feb 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas left review comments

@stof stof stof approved these changes

Assignees
No one assigned
Labels
Feature Mailer Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@ndousson @carsonbot @nicolas-grekas @stof
Morty Proxy This is a proxified and sanitized view of the page, visit original site.