[Form] Skip password hashing on empty password #49459
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| $form = $this->factory | ||
| ->createBuilder('Symfony\Component\Form\Extension\Core\Type\FormType', $user) | ||
| ->add('plainPassword', 'Symfony\Component\Form\Extension\Core\Type\PasswordType', [ |
There was a problem hiding this comment.
let's use ::class even if some other test cases don't
nicolas-grekas
approved these changes
Feb 21, 2023
xabbuh
reviewed
Feb 21, 2023
| @@ -37,6 +37,10 @@ public function __construct( | ||
|
|
||
| public function registerPassword(FormEvent $event) | ||
| { | ||
| if ('' === $event->getData()) { |
89b37a1 to
b4aa3ea
Compare
|
Thank you @Seb33300. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the new
hash_property_pathoption to hash password submitted by forms, we should skip hashing if the submitted password is empty.Because empty passwords are not allowed and saving an empty password hash will prevent the user to login his account:
symfony/src/Symfony/Component/Security/Http/EventListener/CheckCredentialsListener.php
Lines 59 to 62 in 8c19af2
Because a common use case when creating a user profile form is to ignore the "new password" input if it's left blank.