[Cache][Messenger] fixed CallbackInterface support in async expiration handler #49422
Conversation
| @@ -73,7 +73,8 @@ function (CacheItem $item, float $startTime) { | ||
| $startTime = microtime(true); | ||
| $pool = $message->findPool($this->reverseContainer); | ||
| $callback = $message->findCallback($this->reverseContainer); | ||
| $value = $callback($item); | ||
| $save = true; |
There was a problem hiding this comment.
shouldn't this implement the handling of this $save flag ?
There was a problem hiding this comment.
My guess is at this point this is not needed since it was specifically asked to recalculate the cache item asynchronously.
There could be some use cases that I miss though.
There was a problem hiding this comment.
It does look like I am doing something wrong here. But I am also guessing if handling $save will make things worse for someone.
There was a problem hiding this comment.
@nicolas-grekas can you give your opinion on this ?
There was a problem hiding this comment.
My guess is at this point this is not needed since it was specifically asked to recalculate the cache item asynchronously.
Correct!
|
Thank you @AdamKatzDev. |
Adds support for CallbackInterface in EarlyExpirationHandler and thus fixes async cache recomputing for callables that implement CallbackInterface. Earlier similar errors were fixed in #31879.