[Notifier] Replace tests dummy instances by already in place mocks #49398
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
60808d9 to
b7be6f0
Compare
|
Thank you @alexandre-daubois. |
nicolas-grekas
added a commit
that referenced
this pull request
Feb 16, 2023
…lace mocks (alexandre-daubois) This PR was merged into the 5.4 branch. Discussion ---------- [Notifier] Replace tests dummy instances by already in place mocks | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | Fix #49385 (comment) | License | MIT | Doc PR | _NA_ Replacing dummy classes to use already existing mocks and stubs (`MockHttpClient`, `NullLogger` and so on). Commits ------- 83120cb [Notifier] Replace tests dummy instances by already in place mocks
b7be6f0 to
83120cb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacing dummy classes to use already existing mocks and stubs (
MockHttpClient,NullLoggerand so on).