Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Cache] fix trying to load Memcached before checking we can #49395

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 15, 2023

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

When the extension is not installed, using Memcached::* in const breaks before isSupported() could be called.

@carsonbot carsonbot added this to the 5.4 milestone Feb 15, 2023
@nicolas-grekas nicolas-grekas changed the title Fix PHPDoc (wrong order) [Cache] fix trying to load Memcached before checking we can Feb 15, 2023
@carsonbot carsonbot changed the title [Cache] fix trying to load Memcached before checking we can fix trying to load Memcached before checking we can Feb 15, 2023
@fabpot
Copy link
Member

fabpot commented Feb 15, 2023

Thank you @nicolas-grekas.

@fabpot fabpot merged commit eb9ff9b into symfony:5.4 Feb 15, 2023
@nicolas-grekas nicolas-grekas deleted the cache-lazy-memcached branch February 15, 2023 16:23
@nicolas-grekas nicolas-grekas changed the title fix trying to load Memcached before checking we can [Cache] fix trying to load Memcached before checking we can Feb 15, 2023
This was referenced Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.