Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Notifier][WebProfilerBundle] Ignore messages whose getNotification returns null #49310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

[Notifier][WebProfilerBundle] Ignore messages whose getNotification returns null #49310

merged 1 commit into from
Feb 10, 2023

Conversation

MatTheCat
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #49305
License MIT
Doc PR N/A

Make use of Twig’s null-coalescing operator because MessageInterface::getNotification can return null when it exists.

@carsonbot carsonbot added this to the 5.4 milestone Feb 9, 2023
@carsonbot carsonbot changed the title [WebProfilerBundle][Notifier] Ignore messages whose getNotification returns null [Notifier][WebProfilerBundle] Ignore messages whose getNotification returns null Feb 9, 2023
fabpot
fabpot requested changes Feb 10, 2023
View reviewed changes
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/notifier.html.twig Show resolved Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/notifier.html.twig Outdated Show resolved Hide resolved
src/Symfony/Bundle/WebProfilerBundle/Resources/views/Collector/notifier.html.twig Outdated Show resolved Hide resolved
@fabpot
Copy link
Member

fabpot commented Feb 10, 2023

Thank you @MatTheCat.

@fabpot fabpot merged commit f988bdd into symfony:5.4 Feb 10, 2023
@MatTheCat MatTheCat deleted the ticket_49305 branch February 10, 2023 13:03
This was referenced Feb 28, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot requested changes

Assignees
No one assigned
Labels
Bug Notifier Status: Needs Work WebProfilerBundle
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
3 participants
@MatTheCat @fabpot @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.