[HttpClient] Fix data collector #49301
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fancyweb
commented
Feb 8, 2023
| @@ -59,7 +59,8 @@ public function lateCollect() | ||
|
|
||
| $this->data['clients'][$name]['traces'] = array_merge($this->data['clients'][$name]['traces'], $traces); | ||
| $this->data['request_count'] += \count($traces); | ||
| $this->data['error_count'] += $this->data['clients'][$name]['error_count'] += $errorCount; | ||
| $this->data['error_count'] += $errorCount; |
There was a problem hiding this comment.
Global error_count is wrong because on real lateCollect, we readd all errors to the counter.
ging-dev
reviewed
Feb 9, 2023
src/Symfony/Component/HttpClient/DataCollector/HttpClientDataCollector.php
Show resolved
Hide resolved
|
Thank you @fancyweb. |
This was referenced Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It fixes HTTP requests not showing anymore in the profiler panel because
lateCollect()overridesrequest_countto 0.It also fixes the wrong error count.