Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

stop using assertObjectHasAttribute()/assertObjectHasNotAttribute() #49236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 6, 2023
Merged

stop using assertObjectHasAttribute()/assertObjectHasNotAttribute() #49236

merged 1 commit into from
Feb 6, 2023

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Feb 4, 2023

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Tickets related #49233
License MIT
Doc PR

@carsonbot carsonbot added this to the 5.4 milestone Feb 4, 2023
@xabbuh xabbuh requested review from derrabus and OskarStark February 4, 2023 10:30
@OskarStark OskarStark changed the title stop using assertObjectHasAttribute()/assertObjectHasNotAttribute() stop using assertObjectHasAttribute()/assertObjectHasNotAttribute() Feb 4, 2023
GromNaN
GromNaN approved these changes Feb 4, 2023
View reviewed changes
Copy link
Member

@GromNaN GromNaN left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference: sebastianbergmann/phpunit#4601

derrabus
derrabus reviewed Feb 4, 2023
View reviewed changes
src/Symfony/Bridge/Doctrine/Tests/ManagerRegistryTest.php Outdated Show resolved Hide resolved
@xabbuh xabbuh force-pushed the phpunit-assert-object-not-has-attribute branch from e2c8223 to 570d37c Compare February 4, 2023 16:01
phansys
phansys reviewed Feb 6, 2023
View reviewed changes
src/Symfony/Bridge/Doctrine/Tests/ManagerRegistryTest.php Outdated Show resolved Hide resolved
@nicolas-grekas nicolas-grekas force-pushed the phpunit-assert-object-not-has-attribute branch from 570d37c to 442b43c Compare February 6, 2023 08:08
@nicolas-grekas
Copy link
Member

Thank you @xabbuh.

@nicolas-grekas nicolas-grekas merged commit 5f8c7eb into symfony:5.4 Feb 6, 2023
@xabbuh xabbuh deleted the phpunit-assert-object-not-has-attribute branch February 6, 2023 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phansys phansys phansys left review comments

@GromNaN GromNaN GromNaN approved these changes

@derrabus derrabus derrabus approved these changes

@OskarStark OskarStark Awaiting requested review from OskarStark

Assignees
No one assigned
Labels
Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
6 participants
@xabbuh @nicolas-grekas @GromNaN @phansys @derrabus @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.