Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Notifier] [OvhCloud] handle invalid receiver #49025

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2023
Merged

[Notifier] [OvhCloud] handle invalid receiver #49025

merged 1 commit into from
Jan 19, 2023

Conversation

seferov
Copy link
Contributor

@seferov seferov commented Jan 18, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
License MIT

Fix Undefined offset: 0 error when invalid receiver is provided

@seferov seferov requested a review from OskarStark as a code owner January 18, 2023 16:40
@carsonbot carsonbot added this to the 5.4 milestone Jan 18, 2023
OskarStark
OskarStark approved these changes Jan 18, 2023
View reviewed changes
Copy link
Contributor

@OskarStark OskarStark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After my comment

src/Symfony/Component/Notifier/Bridge/OvhCloud/OvhCloudTransport.php Outdated Show resolved Hide resolved
@OskarStark OskarStark requested a review from fabpot January 18, 2023 17:17
@fabpot fabpot force-pushed the notifier/ovhcloud-invalid-receiver branch from 4a1da20 to d41f0bf Compare January 19, 2023 19:18
@fabpot
Copy link
Member

fabpot commented Jan 19, 2023

Thank you @seferov.

@fabpot fabpot merged commit 3bd051f into symfony:5.4 Jan 19, 2023
@seferov seferov deleted the notifier/ovhcloud-invalid-receiver branch January 20, 2023 06:01
This was referenced Jan 24, 2023
Merged
Merged
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fabpot fabpot fabpot approved these changes

@OskarStark OskarStark OskarStark approved these changes

@yceruto yceruto yceruto approved these changes

Assignees
No one assigned
Labels
Bug Notifier Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.
5 participants
@seferov @fabpot @OskarStark @yceruto @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.