Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

Fix BC user_identifier support after deprecation username #48983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 15, 2023

Conversation

vtsykun
Copy link
Contributor

@vtsykun vtsykun commented Jan 15, 2023

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Starting from Symfony 6.2, the {username} string was deprecated in favor of {user_identifier} so here fixed BC support, like it was done for LdapUserProvider

$query = str_replace(['{username}', '{user_identifier}'], $identifier, $this->defaultSearch);

@carsonbot carsonbot added this to the 5.4 milestone Jan 15, 2023
@vtsykun vtsykun changed the title LDAP: Fix BC user_identifier support after deprecation username [LDAP] Fix BC user_identifier support after deprecation username Jan 15, 2023
@carsonbot carsonbot changed the title [LDAP] Fix BC user_identifier support after deprecation username Fix BC user_identifier support after deprecation username Jan 15, 2023
@fabpot
Copy link
Member

fabpot commented Jan 15, 2023

Thank you @vtsykun.

@fabpot fabpot merged commit e9be173 into symfony:5.4 Jan 15, 2023
@vtsykun vtsykun deleted the fix-ldap branch January 21, 2023 21:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.