Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[FrameworkBundle] restore call to addGlobalIgnoredName #48916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

alexislefebvre
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #48792 and replace #48912
License MIT
Doc PR no

The service annotations.dummy_registry is unregistered with doctrine/annotations v2.

This had the unexpected effect to break the call to addGlobalIgnoredName with doctrine/annotations v2 : #48792 (comment)

By using nullOnInvalid instead of ignoreOnInvalid, the call to addGlobalIgnoredName is restored.

These changes can be tested with this reproducer: https://github.com/alexislefebvre/symfony_bug_app_48792

Downgrading and upgrading doctrine/annotations become possible:

composer require doctrine/annotations:^1.13.0 --with-all-dependencies
composer require doctrine/annotations:^2.0 --with-all-dependencies

Thanks to @derrabus: #48912 (comment)

@derrabus
Copy link
Member

derrabus commented Jan 8, 2023

Let's revert the changes to FrameworkExtension.

@carsonbot carsonbot changed the title restore call to addGlobalIgnoredName [FrameworkBundle] restore call to addGlobalIgnoredName Jan 8, 2023
@nicolas-grekas nicolas-grekas force-pushed the 5.4-restore-call-to-addGlobalIgnoredName branch from fbab9a7 to e058874 Compare January 9, 2023 08:25
@nicolas-grekas
Copy link
Member

Thank you @alexislefebvre.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.