[WebProfilerBundle] Fix the usage of web fonts #48822
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yceruto
approved these changes
Dec 29, 2022
fabpot
approved these changes
Dec 29, 2022
|
Thank you @javiereguiluz. |
397acfa to
61f443c
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #48708. As the community found out, the issue was that we're missing the bold style of the embedded web font.
However, while fixing this issue we realized that adding the normal + bold styles would increase the page size too much. We discussed this internally in the Core Team and decided to use a different approach: let's use a variable font, which will allow us to use many different font weights with a single font file.
To do that, we had to change the previous web font (Ubuntu Mono) by a new font (JetBrains Mono). This is the same font used in symfony.com docs, in PhpStorm IDE, etc.