[Dotenv] Handle dynamic variables in multiple .env files #48636
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
|
Hey! I think @deguif has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the dynamic variables not using the final value of a property.
It handles only one level of dynamicity (e.g. we can't have
var->var->const, onlyvar->const).The process is basically to have two passes when reading the .env files; the first one is to parse constants and the second one is to resolve variables using the calculated values.
It will also remove the need to care about the variables' order (if this gets accepted, there would be a change needed in the documentation on this page).
I would like some feedback (first contribution and currently learning the framework), mostly on te
loadEnv()function, since @nicolas-grekas was talking about a possible won't fix status for this in issue #40717.