-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[WebProfilerBundle] Use same color as other icons for the close toolbar btn #48476
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ogizanagi where does this happen to you? On macOS + Chrome or Firefox I see the close button with the right color without having to do this change: And the color is maintained when hovering the mouse pointer: |
@javiereguiluz : It happens to me and a teammate, with Symfony 6.2.0 using on macOS + Chrome 108.0.5359.71, Firefox and Safari as well 🤔 |
It's strange that I don't see this issue when using the same browser + OS. In any case, your contribution is perfect and it doesn't hurt at all to define the color explicitly. So, let's merge this. Thanks! |
Thank you @ogizanagi. |
Same color as
sf-toolbar-icon
, which has better contrast: