Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[WebProfilerBundle] Use same color as other icons for the close toolbar btn #48476

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 6, 2022

Conversation

ogizanagi
Copy link
Contributor

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

Same color as sf-toolbar-icon, which has better contrast:

Before After
SCR-20221205-dsi SCR-20221205-dpf-2

@javiereguiluz
Copy link
Member

@ogizanagi where does this happen to you? On macOS + Chrome or Firefox I see the close button with the right color without having to do this change:

close-button

And the color is maintained when hovering the mouse pointer:

close-button-in-action

@ogizanagi
Copy link
Contributor Author

@javiereguiluz : It happens to me and a teammate, with Symfony 6.2.0 using on macOS + Chrome 108.0.5359.71, Firefox and Safari as well 🤔

@javiereguiluz
Copy link
Member

It's strange that I don't see this issue when using the same browser + OS.

In any case, your contribution is perfect and it doesn't hurt at all to define the color explicitly. So, let's merge this. Thanks!

@ogizanagi
Copy link
Contributor Author

ogizanagi commented Dec 5, 2022

To complete, here is what shows the Chrome inspector on the <svg> element:

SCR-20221205-o9m

SCR-20221205-o8r

@javiereguiluz
Copy link
Member

Thanks for sharing this. Now I know what happened ... the app.css file of my apps apply a color: inherit to certain form elements. That's the difference with your app and that's why I couldn't see this issue while working on the redesign 🙈

inspector-svg-element

@fabpot
Copy link
Member

fabpot commented Dec 6, 2022

Thank you @ogizanagi.

@fabpot fabpot merged commit 2b292e7 into symfony:6.2 Dec 6, 2022
@ogizanagi ogizanagi deleted the profiler-close-btn branch December 6, 2022 13:13
@fabpot fabpot mentioned this pull request Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.