Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Clock] Implement PSR-20 #48320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 25, 2022
Merged

[Clock] Implement PSR-20 #48320

merged 1 commit into from
Nov 25, 2022

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Nov 25, 2022

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Anticipating the creation of psr/clock v1.0
php-fig/fig-standards#1289

/cc @heiglandreas

@94noni
Copy link
Contributor

94noni commented Nov 25, 2022

You loose no time 🕐 hahaha

src/Symfony/Component/Clock/ClockInterface.php Outdated Show resolved Hide resolved
@derrabus
Copy link
Member

Shouldn't we require psr/clock in the root composer.json as well?

@derrabus
Copy link
Member

Is this for 6.2 or 6.3? The PR description says 6.2, but you're targeting the 6.3 branch.

@nicolas-grekas
Copy link
Member Author

Right, target + composer.json updated.

@Jean85
Copy link
Contributor

Jean85 commented Nov 25, 2022

1.0 is tagged! 🎉 just restart the CI 😄

@nicolas-grekas
Copy link
Member Author

Rebased, ready !

@fabpot
Copy link
Member

fabpot commented Nov 25, 2022

Thank you @nicolas-grekas.

@fabpot fabpot merged commit ea658c4 into symfony:6.2 Nov 25, 2022
@fabpot fabpot mentioned this pull request Nov 28, 2022
@nicolas-grekas nicolas-grekas deleted the clock branch December 5, 2022 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.