-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[Clock] Implement PSR-20 #48320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
[Clock] Implement PSR-20 #48320
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7ac939a
to
aa828cd
Compare
You loose no time 🕐 hahaha |
stof
reviewed
Nov 25, 2022
aa828cd
to
a2f82c6
Compare
Shouldn't we require |
Is this for 6.2 or 6.3? The PR description says 6.2, but you're targeting the 6.3 branch. |
a2f82c6
to
ff21357
Compare
Right, target + composer.json updated. |
1.0 is tagged! 🎉 just restart the CI 😄 |
ff21357
to
138dda9
Compare
chalasr
approved these changes
Nov 25, 2022
138dda9
to
03fc7e1
Compare
Rebased, ready ! |
xabbuh
approved these changes
Nov 25, 2022
Thank you @nicolas-grekas. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Anticipating the creation of psr/clock v1.0
php-fig/fig-standards#1289
/cc @heiglandreas