Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[HttpKernel] Fix message for unresovable arguments of invokable controllers #48273

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 22, 2022
Merged

[HttpKernel] Fix message for unresovable arguments of invokable controllers #48273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions 5 ...ony/Component/HttpKernel/Controller/ArgumentResolver/NotTaggedControllerValueResolver.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,8 +69,9 @@ public function resolve(Request $request, ArgumentMetadata $argument): iterable
}

if (!$this->container->has($controller)) {
$i = strrpos($controller, ':');
$controller = substr($controller, 0, $i).strtolower(substr($controller, $i));
$controller = (false !== $i = strrpos($controller, ':'))
? substr($controller, 0, $i).strtolower(substr($controller, $i))
: $controller.'::__invoke';
}

$what = sprintf('argument $%s of "%s()"', $argument->getName(), $controller);
Expand Down
11 changes: 11 additions & 0 deletions 11 ...ent/HttpKernel/Tests/Controller/ArgumentResolver/NotTaggedControllerValueResolverTest.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,17 @@ public function testControllerNameIsAnArray()
$resolver->resolve($request, $argument);
}

public function testInvokableController()
{
$this->expectException(RuntimeException::class);
$this->expectExceptionMessage('Could not resolve argument $dummy of "App\Controller\Mine::__invoke()", maybe you forgot to register the controller as a service or missed tagging it with the "controller.service_arguments"?');
$resolver = new NotTaggedControllerValueResolver(new ServiceLocator([]));
$argument = new ArgumentMetadata('dummy', \stdClass::class, false, false, null);
$request = $this->requestWithAttributes(['_controller' => 'App\Controller\Mine']);
$this->assertTrue($resolver->supports($request, $argument));
$resolver->resolve($request, $argument);
}

private function requestWithAttributes(array $attributes)
{
$request = Request::create('/');
Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.