[Translation] [Lokalize] Configure replace_breaks to prevent issues with multilines translations
#48222
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…with multilines translations
replace_breaks to prevent issues with multilines translationsreplace_breaks to prevent issues with multilines translations
stof
approved these changes
Nov 16, 2022
|
Failures are unrelated. |
OskarStark
reviewed
Nov 16, 2022
| @@ -562,6 +562,7 @@ public function testReadForOneLocaleAndOneDomain(string $locale, string $domain, | ||
| 'filter_langs' => [$locale], | ||
| 'filter_filenames' => [$domain.'.xliff'], | ||
| 'export_empty_as' => 'skip', | ||
| 'replace_breaks' => false, |
There was a problem hiding this comment.
What about extending the test with your use case?
There was a problem hiding this comment.
Since we don't contact Lokalise API during tests, is it really useful?
|
Related to #45368, I think both PR are needed to fix the issue of ICU translations pulling from Lokalise. |
fabpot
approved these changes
Nov 19, 2022
|
Thank you @Kocal. |
Merged
This was referenced Nov 28, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, as seen with @welcoMattic in private messages, I faced an issue when pulling translations from Lokalise.
Given the following translation, with newlines:
When I pull it, this is what the translation looks like in the Symfony's
.xliff:Which leads to a syntax issue for the ICU formatter:
Using
replace_breaks: falsewill fix this issue by preserving newlines: