Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Mime] rename Part/BodyFile to Part/File #48060

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 1, 2022

Conversation

nicolas-grekas
Copy link
Member

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Was proposed during a chat within the core-team.

/cc @javiereguiluz

@maxbeckers
Copy link
Contributor

Please reorder the use statements as the fabbot mentioned

Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

once fabbot is ok

@chalasr
Copy link
Member

chalasr commented Oct 31, 2022

No markdown diff, did we forget to add some changelog entry?

@nicolas-grekas
Copy link
Member Author

Updated!

src/Symfony/Component/Mime/Part/File.php Show resolved Hide resolved
@fabpot
Copy link
Member

fabpot commented Nov 1, 2022

Thank you @nicolas-grekas.

@fabpot fabpot merged commit 652dc7d into symfony:6.2 Nov 1, 2022
javiereguiluz added a commit to symfony/symfony-docs that referenced this pull request Aug 28, 2023
This PR was squashed before being merged into the 6.3 branch.

Discussion
----------

[Mailer] Fix attachment changes

The title of symfony/symfony#47711 did not change before merge, but actually only `attachPart` has been deprecated (renamed) in favor of `addPart`.
I did not reintroduce the other methods as they may be deprecated in 7.1, so no need to document a way that may change in a few months.
Also the `BodyFile` class has been renamed in symfony/symfony#48060 whereas the use in the example code was correct.

Commits
-------

46923d0 [Mailer] Fix attachment changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.