[Validator] Add the type for ConstraintValidatorTestCase::createValidator #48012
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
stof
commented
Oct 27, 2022
| Q | A |
|---|---|
| Branch? | 6.2 |
| Bug fix? | no |
| New feature? | no |
| Deprecations? | no |
| Tickets | n/a |
| License | MIT |
| Doc PR | n/a |
chalasr
approved these changes
Oct 27, 2022
derrabus
approved these changes
Oct 27, 2022
fancyweb
approved these changes
Oct 27, 2022
|
Do we need to add the changed file in the list of excluded classes in |
|
indeed, we should (and ideally, we should update the patcher to account for |
|
Looking at it, the patcher handles template type only when the method has a native return type. Maybe this should be typed like that for now, to account for adding a native return type in Symfony 7.0: /**
* @return ConstraintValidatorInterface
* @psalm-return T
*/
abstract protected function createValidator();This way, in 7.0, we can add |
|
@stof that'd make sense to me. |
|
I updated the PR |
yceruto
approved these changes
Nov 2, 2022
nicolas-grekas
added a commit
that referenced
this pull request
Nov 2, 2022
…t the patcher (stof) This PR was merged into the 6.2 branch. Discussion ---------- Fix the DataTransformerInterface generic types to support the patcher | Q | A | ------------- | --- | Branch? | 6.2 | Bug fix? | no | New feature? | no | Deprecations? | no | Tickets | | License | MIT | Doc PR | n/a The type patcher adding return types handles template types only for methods that already have a return type. As `DataTransformerInterface` is not typed yet in Symfony 6.x, we need to keep the future native types in ``@return`` for the patcher tool. This puts the generic type (introduced in #47412) in ``@psalm`-return`, as done in #48012 (I detected this issue when regenerating the return type for that other PR) Commits ------- d9fd5c7 Fix the DataTransformerInterface generic types to support the patcher
|
rebase needed |
|
@nicolas-grekas The rebase is done |
derrabus
approved these changes
Nov 8, 2022
src/Symfony/Bridge/Doctrine/Tests/Validator/Constraints/UniqueEntityValidatorTest.php
Outdated
Show resolved
Hide resolved
36604b9 to
894a449
Compare
|
Thank you @stof. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.