Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[DoctrineBridge] Deprecate calling ContainerAwareEventManager::getListeners() without event name #47864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

derrabus
Copy link
Member

Q A
Branch? 6.2
Bug fix? no
New feature? no
Deprecations? yes
Tickets N/A
License MIT
Doc PR N/A

With EventManager 1.2, calling EventManager::getListeners() without an event name has been deprecated. We should do the same for our ContainerAwareEventManager.

@carsonbot carsonbot changed the title Deprecate calling ContainerAwareEventManager::getListeners() without event name [DoctrineBridge] Deprecate calling ContainerAwareEventManager::getListeners() without event name Oct 14, 2022
@carsonbot carsonbot added this to the 6.2 milestone Oct 14, 2022
src/Symfony/Bridge/Doctrine/ContainerAwareEventManager.php Outdated Show resolved Hide resolved
@derrabus derrabus force-pushed the deprecate/get-listeners-without-event branch 2 times, most recently from 324702b to 8211fe6 Compare October 15, 2022 09:01
@derrabus derrabus requested a review from stof October 15, 2022 09:02
@derrabus
Copy link
Member Author

Ready.

src/Symfony/Bridge/Doctrine/ContainerAwareEventManager.php Outdated Show resolved Hide resolved
@derrabus derrabus force-pushed the deprecate/get-listeners-without-event branch from 8211fe6 to af24827 Compare October 15, 2022 10:31
@derrabus derrabus merged commit 1ccb56f into symfony:6.2 Oct 15, 2022
@derrabus derrabus deleted the deprecate/get-listeners-without-event branch October 15, 2022 10:40
@fabpot fabpot mentioned this pull request Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.