Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[FrameworkBundle] Fix passing serializer.default_context option to normalizers #47637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -78,7 +78,8 @@

// Normalizer
->set('serializer.normalizer.constraint_violation_list', ConstraintViolationListNormalizer::class)
->args([[], service('serializer.name_converter.metadata_aware')])
->args([1 => service('serializer.name_converter.metadata_aware')])
->autowire(true)
->tag('serializer.normalizer', ['priority' => -915])

->set('serializer.normalizer.mime_message', MimeMessageNormalizer::class)
Expand Down Expand Up @@ -124,7 +125,6 @@
service('property_info')->ignoreOnInvalid(),
service('serializer.mapping.class_discriminator_resolver')->ignoreOnInvalid(),
null,
[],
nicolas-grekas marked this conversation as resolved.
Show resolved Hide resolved
])
->tag('serializer.normalizer', ['priority' => -1000])

Expand All @@ -137,7 +137,6 @@
service('property_info')->ignoreOnInvalid(),
service('serializer.mapping.class_discriminator_resolver')->ignoreOnInvalid(),
null,
[],
])

->alias(PropertyNormalizer::class, 'serializer.normalizer.property')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,41 @@ public function testDeserializeArrayOfObject()

$this->assertEquals($expected, $result);
}

/**
* @dataProvider provideNormalizersAndEncodersWithDefaultContextOption
*/
public function testNormalizersAndEncodersUseDefaultContextConfigOption(string $normalizerId)
{
static::bootKernel(['test_case' => 'Serializer']);

$normalizer = static::getContainer()->get($normalizerId);

$reflectionObject = new \ReflectionObject($normalizer);
$property = $reflectionObject->getProperty('defaultContext');
$property->setAccessible(true);

$defaultContext = $property->getValue($normalizer);

self::assertArrayHasKey('fake_context_option', $defaultContext);
self::assertEquals('foo', $defaultContext['fake_context_option']);
}

public function provideNormalizersAndEncodersWithDefaultContextOption(): array
{
return [
['serializer.normalizer.constraint_violation_list.alias'],
['serializer.normalizer.dateinterval.alias'],
['serializer.normalizer.datetime.alias'],
['serializer.normalizer.json_serializable.alias'],
['serializer.normalizer.problem.alias'],
['serializer.normalizer.uid.alias'],
['serializer.normalizer.object.alias'],
['serializer.encoder.xml.alias'],
['serializer.encoder.yaml.alias'],
['serializer.encoder.csv.alias'],
];
}
}

class Foo
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,54 @@ framework:
enabled: true
default_context:
enable_max_depth: true
fake_context_option: foo
property_info: { enabled: true }

services:
serializer.alias:
alias: serializer
public: true

serializer.normalizer.constraint_violation_list.alias:
alias: serializer.normalizer.constraint_violation_list
public: true

serializer.normalizer.dateinterval.alias:
alias: serializer.normalizer.dateinterval
public: true

serializer.normalizer.datetime.alias:
alias: serializer.normalizer.datetime
public: true

serializer.normalizer.json_serializable.alias:
alias: serializer.normalizer.json_serializable
public: true

serializer.normalizer.problem.alias:
alias: serializer.normalizer.problem
public: true

serializer.normalizer.uid.alias:
alias: serializer.normalizer.uid
public: true

serializer.normalizer.property.alias:
alias: serializer.normalizer.property
public: true

serializer.normalizer.object.alias:
alias: serializer.normalizer.object
public: true

serializer.encoder.xml.alias:
alias: serializer.encoder.xml
public: true

serializer.encoder.yaml.alias:
alias: serializer.encoder.yaml
public: true

serializer.encoder.csv.alias:
alias: serializer.encoder.csv
public: true
Morty Proxy This is a proxified and sanitized view of the page, visit original site.