Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[HttpFoundation] Always return strings from accept headers #47530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 9, 2022

Conversation

ausi
Copy link
Contributor

@ausi ausi commented Sep 9, 2022

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets -
License MIT
Doc PR -

Items retrieved from the Accept HTTP headers should always be strings.

Related: contao/contao#5261

src/Symfony/Component/HttpFoundation/Tests/RequestTest.php Outdated Show resolved Hide resolved
@carsonbot carsonbot changed the title Always return strings from accept headers [HttpFoundation] Always return strings from accept headers Sep 9, 2022
@xabbuh xabbuh modified the milestones: 5.4, 4.4 Sep 9, 2022
@nicolas-grekas nicolas-grekas changed the base branch from 5.4 to 4.4 September 9, 2022 16:01
Copy link
Member

@nicolas-grekas nicolas-grekas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I changed the target of the PR to 4.4)

@fabpot
Copy link
Member

fabpot commented Sep 9, 2022

Thank you @ausi.

@fabpot fabpot merged commit 7023db1 into symfony:4.4 Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.