Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Form][PropertyAccess] Allow optional property accesses #47511

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 1, 2022
Merged

[Form][PropertyAccess] Allow optional property accesses #47511

merged 1 commit into from
Oct 1, 2022

Conversation

fsoedjede
Copy link
Contributor

@fsoedjede fsoedjede commented Sep 7, 2022 •
edited
Loading

Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? yes
Tickets Fix #34483
License MIT
Doc PR symfony/symfony-docs#17288

This PR is basically a copy of #34497 with some minor changes.

I needed it and I have some time now to help advance in implementing it.

TODO

  • Add nullsafe operator usage
  • Update unit test
  • Update documentation

Regards

@carsonbot carsonbot added this to the 6.2 milestone Sep 7, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.2 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@carsonbot carsonbot changed the title [PropertyAccess][Form] Allow optional property accesses [Form][PropertyAccess] Allow optional property accesses Sep 7, 2022
@fsoedjede fsoedjede force-pushed the 34483-property-access-add-nullsafe-operator branch from 698ca57 to 1a58136 Compare September 7, 2022 17:53
@carsonbot
Copy link

Hey!

I think @b1rdex has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

b1rdex
b1rdex reviewed Sep 8, 2022
View reviewed changes
UPGRADE-6.2.md Outdated Show resolved Hide resolved
src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php Show resolved Hide resolved
src/Symfony/Component/PropertyAccess/Tests/PropertyAccessorTest.php Show resolved Hide resolved
src/Symfony/Component/PropertyAccess/PropertyPath.php Outdated Show resolved Hide resolved
src/Symfony/Component/PropertyAccess/PropertyPath.php Show resolved Hide resolved
@fsoedjede fsoedjede requested review from b1rdex and removed request for xabbuh and yceruto September 22, 2022 19:22
@fsoedjede
Copy link
Contributor Author

@ogizanagi would you mind check this PR please

@fsoedjede fsoedjede force-pushed the 34483-property-access-add-nullsafe-operator branch from 0d1f7ac to 6455feb Compare September 22, 2022 19:41
@fsoedjede fsoedjede mentioned this pull request Sep 22, 2022
Merged
ogizanagi
ogizanagi approved these changes Sep 24, 2022
View reviewed changes
Copy link
Contributor

@ogizanagi ogizanagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for taking over this feature request @fsoedjede

@fabpot
Copy link
Member

fabpot commented Oct 1, 2022

Thank you @fsoedjede.

@fabpot fabpot merged commit d9462d9 into symfony:6.2 Oct 1, 2022
@fsoedjede fsoedjede deleted the 34483-property-access-add-nullsafe-operator branch October 1, 2022 17:38
javiereguiluz added a commit to javiereguiluz/symfony-docs that referenced this pull request Oct 4, 2022
@javiereguiluz
minor symfony#17288 [PropertyAccess] Document nullsafe operator usage…
dabd9ce 
… (fsoedjede)

This PR was merged into the 6.2 branch.

Discussion
----------

[PropertyAccess] Document nullsafe operator usage

<!--

If your pull request fixes a BUG, use the oldest maintained branch that contains
the bug (see https://symfony.com/releases for the list of maintained branches).

If your pull request documents a NEW FEATURE, use the same Symfony branch where
the feature was introduced (and `6.x` for features of unreleased versions).

-->

Doc PR for symfony/symfony#47511

Commits
-------

6a5d2ee [PropertyAccess] Document nullsafe operator usage
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ogizanagi ogizanagi ogizanagi approved these changes

@b1rdex b1rdex Awaiting requested review from b1rdex

Assignees
No one assigned
Labels
Deprecation Feature Form PropertyAccess Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.

[PropertyAccess] Add nullsafe operator support
5 participants
@fsoedjede @carsonbot @fabpot @b1rdex @ogizanagi
Morty Proxy This is a proxified and sanitized view of the page, visit original site.