[Filesystem] makePathRelative with existing files, remove ending / #47424
+5
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug description: Filesystem::makePathRelative adds wrongly an ending slash / to a resulting relative path, although provided
endPath
points to existing file.Situation tl;dr:
Discussion: I thought at first that the method should be applied only to folders. However, Filesystem provides operations for files and folders. The provided relative path is therefore unexpected. The problem was discussed in pull request #40051 without solving the issue because of the awareness of causing troubles in existing codebases. This issue exists because folder paths are occasionally defined with an ending slash. In the closed pull request, a solution was proposed that did not check if an
endPath
targets an existing file.Deprecations: There should be no deprecations. Those who wanted to solve the described problem checked the unnecessary presence of the last slash.
Reproduce bug:
Tests: Filesystem has no tests that are trying to test with files instead of folders. New tests have to be defined. My PHP knowledge is not sufficient to create these tests reliably.