Fix broken request stack state if throwable is thrown. #47358
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39674e0 to
f55c39d
Compare
fabpot
reviewed
Aug 22, 2022
|
Added tests, tho I'm not quite sure what's the best way to throw Throwable. |
b1a7414 to
eb4b5aa
Compare
fabpot
requested changes
Aug 22, 2022
4a3802a to
9512ce0
Compare
|
Instead of a test requiring a file with a syntax error, it would be simpler to make a function trigger a |
9512ce0 to
e5c4190
Compare
Ah yes, totally forgot about it. Thanks! |
chalasr
reviewed
Aug 22, 2022
e5c4190 to
e35d6ba
Compare
fabpot
approved these changes
Aug 22, 2022
|
Thank you @Warxcell. |
This was referenced Aug 26, 2022
Merged
Merged
Merged
Merged
Merged
nicolas-grekas
added a commit
that referenced
this pull request
Oct 18, 2022
… exception (krzyc) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [HttpKernel] Fix empty request stack when terminating with exception | Q | A | ------------- | --- | Branch? | 4.4, 5.4, 6.0, 6.1, 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #47577 | License | MIT | Doc PR | After #47358 the RequestStack is empty when request terminates with exception, which prevents SecurityDataCollector to generate logout URL and generates fatal error. Commits ------- e4d6e7b [HttpKernel] Fix empty request stack when terminating with exception
symfony-splitter
pushed a commit
to symfony/http-kernel
that referenced
this pull request
Oct 18, 2022
… exception (krzyc) This PR was squashed before being merged into the 4.4 branch. Discussion ---------- [HttpKernel] Fix empty request stack when terminating with exception | Q | A | ------------- | --- | Branch? | 4.4, 5.4, 6.0, 6.1, 6.2 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | Fix #47577 | License | MIT | Doc PR | After symfony/symfony#47358 the RequestStack is empty when request terminates with exception, which prevents SecurityDataCollector to generate logout URL and generates fatal error. Commits ------- e4d6e7b4ba [HttpKernel] Fix empty request stack when terminating with exception
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using long-running server (like roadrunner) if Throwable is thrown - requestStack is never pop out and it stays in broken state and next requests receive previous request object.