[DependencyInjection] Container building optimization #47176
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicolas-grekas can you look? |
|
Adding this to the 6.2 milestone as performance optimisations should be handled as new features. |
|
@nicolas-grekas can you look once again? |
nicolas-grekas
approved these changes
Oct 19, 2022
Will be this optimization available in 5.4? |
|
5.4 accepts only bug fixes now. Only 6.2 gets improvements. |
Too bad for my project, but it will a motivation for updating %) |
fabpot
approved these changes
Oct 20, 2022
|
Thank you @sveneld. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When you have to much env variables and many services in your container, container compilаtion can take much time due to the function stripos which is called much time.
It happens because method freezeAfterProcessing try to find env placeholders in config, but make it in two foreach.
So i offer to get all possible placeholders with preg_match_all and do not use stripos for each placeholed.
Same situation with method resolveEnvPlaceholders. But in this method we should left stripos for hard cases when in value could be something like this 'env_1418b707a69b8575_const_HOST_74bcc04c4799f2ca10fb754fe5581c89env_1418b707a69b8575_const_CORE_URL_91ef68034c1e9e8b58c13725d3bafdc0'
In my project it helps me to save 40 seconds in container building.
Related to my previous fix #44876