[DoctrineBridge] Avoid calling AbstractPlatform::hasNativeGuidType()
#46985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AbstractPlatform::hasNativeGuidType()AbstractPlatform::hasNativeGuidType()
stof
reviewed
Jul 19, 2022
|
👍 for this with stof's suggestion as it makes the code more efficient and future proof than it is currently. |
dba6e86 to
f01c9a4
Compare
stof
reviewed
Jul 19, 2022
f01c9a4 to
5d882ce
Compare
chalasr
approved these changes
Jul 19, 2022
alamirault
approved these changes
Jul 19, 2022
fabpot
approved these changes
Jul 20, 2022
|
Thank you @derrabus. |
This was referenced Jul 29, 2022
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
AbstractPlatform::hasNativeGuidType()has been deprecated in Doctrine DBAL. This PR inlines the logic of that method where we need it.Furthermore, I took the liberty to refactor the corresponding tests a little. We don't really need to mock
AbstractPlatformbecause we can work with actual instances. This also allows us to test the behavior of our implementation on different platforms.