[HttpKernel] Declare properties used by CacheAttributeListenerTest explicitly #46945
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0c6ab78 to
f0d0799
Compare
derrabus
commented
Jul 14, 2022
| @@ -294,12 +300,12 @@ public function testAttribute() | ||
| $this->assertSame(CacheAttributeController::CLASS_SMAXAGE, $response->getMaxAge()); | ||
| } | ||
|
|
||
| private function createRequest(Cache $cache = null) |
There was a problem hiding this comment.
Minor: We always pass the argument and we never pass null.
|
I disagree with fabbot. 🙂 |
nicolas-grekas
approved these changes
Jul 14, 2022
GromNaN
approved these changes
Jul 14, 2022
|
Good catch, thanks @derrabus. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A test case introduced by #46880 triggers deprecation notices on PHP 8.2 because none of the properties used is declared. This PR fixes the build by adding explicit property declarations.