Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[HttpKernel] Declare properties used by CacheAttributeListenerTest explicitly #46945

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 14, 2022

Conversation

derrabus
Copy link
Member

Q A
Branch? 6.2
Bug fix? yes
New feature? no
Deprecations? no
Tickets N/A
License MIT
Doc PR N/A

A test case introduced by #46880 triggers deprecation notices on PHP 8.2 because none of the properties used is declared. This PR fixes the build by adding explicit property declarations.

@@ -294,12 +300,12 @@ public function testAttribute()
$this->assertSame(CacheAttributeController::CLASS_SMAXAGE, $response->getMaxAge());
}

private function createRequest(Cache $cache = null)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor: We always pass the argument and we never pass null.

@derrabus
Copy link
Member Author

I disagree with fabbot. 🙂

@chalasr
Copy link
Member

chalasr commented Jul 14, 2022

Good catch, thanks @derrabus.

@chalasr chalasr merged commit 4b4f334 into symfony:6.2 Jul 14, 2022
@derrabus derrabus deleted the bugfix/fix-tests branch July 15, 2022 05:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants
Morty Proxy This is a proxified and sanitized view of the page, visit original site.