Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[DependencyInjection] Add Enum Env Var Processor #46564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 27, 2022
Merged

[DependencyInjection] Add Enum Env Var Processor #46564

merged 1 commit into from
Jun 27, 2022

Conversation

jack-worman
Copy link
Contributor

@jack-worman jack-worman commented Jun 2, 2022 •
edited
Loading

Q A
Branch? 6.2
Bug fix? no
New feature? yes
Deprecations? no
Tickets N/A
License MIT
Doc PR waiting on approval of feature

Add the ability to transform env variables into \BackedEnums.

For example, you could now autowire an enum from an environment variable:

<?php

use Symfony\Component\DependencyInjection\Attribute\Autowire;

enum AppEnv: string {
   case Test = 'test';
   case Dev = 'dev';
   case Stage = 'stage';
   case Prod = 'prod';
}

class Foo {
    public function __construct(
        #[Autowire('%env(enum:'.AppEnv::class.':APP_ENV)%')]
        private AppEnv $appEnv,
    ) {}
}

@carsonbot carsonbot added this to the 6.2 milestone Jun 2, 2022
@carsonbot
Copy link

Hey!

I think @ruudk has recently worked with this code. Maybe they can help review this?

Cheers!

Carsonbot

@nicolas-grekas
Copy link
Member

This might miss some pieces as I think some regexps like this one might prevent using FQCN in %env()% parameters:

symfony/src/Symfony/Component/DependencyInjection/ParameterBag/EnvPlaceholderParameterBag.php

Line 47 in bbf25d6

if (!preg_match('/^(?:[-.\w]*+:)*+\w++$/', $env)) {

@nicolas-grekas
Copy link
Member

Please update the description of the PR to make it clear what you're proposing. I could guess by looking at the tests, but providing a proper PR description is nonetheless a good thing to help ppl understand what this is about, and start the doc later on.

nicolas-grekas
nicolas-grekas reviewed Jun 24, 2022
View reviewed changes
src/Symfony/Component/DependencyInjection/CHANGELOG.md Outdated Show resolved Hide resolved
src/Symfony/Component/DependencyInjection/EnvVarProcessor.php Outdated Show resolved Hide resolved
src/Symfony/Component/DependencyInjection/Loader/Configurator/EnvConfigurator.php Show resolved Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Fixtures/IntBackedEnum.php Outdated Show resolved Hide resolved
src/Symfony/Component/DependencyInjection/Tests/Loader/Configurator/EnvConfiguratorTest.php Outdated Show resolved Hide resolved
nicolas-grekas
nicolas-grekas approved these changes Jun 27, 2022
View reviewed changes
src/Symfony/Component/DependencyInjection/EnvVarProcessor.php Outdated Show resolved Hide resolved
nicolas-grekas
nicolas-grekas reviewed Jun 27, 2022
View reviewed changes
src/Symfony/Component/DependencyInjection/EnvVarProcessor.php Outdated Show resolved Hide resolved
@nicolas-grekas
Copy link
Member

A next step could be to find a way to make autowiring do its part, so that the enum: prefix wouldn't be needed.
But that's for another PR :)

👍

@nicolas-grekas
Copy link
Member

nicolas-grekas commented Jun 27, 2022 •
edited
Loading

Can you please rebase on latest 6.2? We don't merge PRs with merge commits. If you want to squash while doing so, please do (we'll do it when merging otherwise.)

@jack-worman
Copy link
Contributor Author

Rebase and squash is done!

@nicolas-grekas
Copy link
Member

Thank you @jack-worman.

@nicolas-grekas nicolas-grekas mentioned this pull request Jun 27, 2022
Closed
@nicolas-grekas nicolas-grekas merged commit 308652c into symfony:6.2 Jun 27, 2022
@jack-worman jack-worman deleted the EnumEnvVarProcessor branch June 27, 2022 18:49
@fabpot fabpot mentioned this pull request Oct 24, 2022
Merged
@nicolas-grekas nicolas-grekas mentioned this pull request Dec 6, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@stof stof stof approved these changes

Assignees
No one assigned
Labels
DependencyInjection Feature Status: Reviewed
Projects
None yet
Milestone
6.2
Development

Successfully merging this pull request may close these issues.
4 participants
@jack-worman @carsonbot @nicolas-grekas @stof
Morty Proxy This is a proxified and sanitized view of the page, visit original site.