[WebProfilerBundle] Update the icon of the Serializer profiler panel #46252
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chalasr
approved these changes
May 4, 2022
fabpot
approved these changes
May 4, 2022
|
Thank you @javiereguiluz. |
nicolas-grekas
added a commit
that referenced
this pull request
May 5, 2022
…javiereguiluz) This PR was squashed before being merged into the 6.1 branch. Discussion ---------- [WebProfilerBundle] Fix tests about web profiler icons | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | yes | New feature? | no | Deprecations? | no | Tickets | - | License | MIT | Doc PR | - The new icon added in #46252 broke tests. This PR fixes them. Commits ------- 884c8cd [WebProfilerBundle] Fix tests about web profiler icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the PR that added the Serializer profiler panel, the new icon was left as a pending thing. See #45656 (comment)
This PR adds the new icon and it looks like this:
Two comments:
(1) The icon style doesn't 100% match the style of the other icons. Don't worry about that. We plan to update all icons for Symfony 6.2 and they all will use that style.
(2) I know the icon might not be super clear and I'm open to better suggestions for this icon ... but it seems that it's impossible to conceptualize the "serializer" concept in an icon. See the biggest icon libraries in the world:
So, I did this: I looked for "serializer" in Google Images (https://www.google.com/search?q=serializer&tbm=isch) and found that most images are block diagrams with lots of horizontal arrows. That's why I opted for the "two horizontal arrows" icon.