Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[Form] ensure that already loaded lists are always reused #46101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Form] ensure that already loaded lists are always reused #46101

wants to merge 1 commit into from

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Apr 19, 2022 •
edited
Loading

Q A
Branch? 4.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets
License MIT
Doc PR

alternative to #46098

@xabbuh xabbuh added this to the 4.4 milestone Apr 19, 2022
@xabbuh xabbuh requested a review from yceruto as a code owner April 19, 2022 08:21
@carsonbot carsonbot modified the milestones: 4.4, 6.1 Apr 19, 2022
@xabbuh xabbuh mentioned this pull request Apr 19, 2022
Merged
@xabbuh xabbuh changed the base branch from 6.1 to 4.4 April 19, 2022 08:30
@xabbuh xabbuh force-pushed the form-lazy-choice-list branch from 0538c3b to 601fabe Compare April 19, 2022 08:30
@xabbuh xabbuh modified the milestones: 6.1, 4.4 Apr 19, 2022
@nicolas-grekas
Copy link
Member

Should be closed? Rebased after #46098?

@HeahDude
Copy link
Contributor

We discussed with Christian about adding back this optimisation (not a bug fix) to 6.2.

@xabbuh can we close here? I can send the PR for 6.2 if you want.

@xabbuh xabbuh closed this May 21, 2022
@xabbuh xabbuh deleted the form-lazy-choice-list branch May 21, 2022 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yceruto yceruto Awaiting requested review from yceruto yceruto is a code owner

Assignees
No one assigned
Labels
Bug Form Status: Needs Review
Projects
None yet
Milestone
4.4
Development

Successfully merging this pull request may close these issues.
4 participants
@xabbuh @nicolas-grekas @HeahDude @carsonbot
Morty Proxy This is a proxified and sanitized view of the page, visit original site.