[Validator] Supports backed enum in constraint groups #45570
Conversation
|
It might be problematic that two values from different enums have the same value. When I would use enums for validation groups, I think I would expect those to result in different validation groups. When used manually, I would have prefixed the groups like enum FooEnum
{
case Create = 'C';
case Update = 'U';
}
enum BarEnum
{
case Combine = 'C';
case Unset = 'U';
} |
| @@ -197,14 +197,32 @@ protected function normalizeOptions(mixed $options): array | ||
| public function __set(string $option, mixed $value) | ||
| { | ||
| if ('groups' === $option) { | ||
| $this->groups = (array) $value; | ||
| $this->groups = $this->normalizeGroups((array) $value); |
There was a problem hiding this comment.
I'd rather turn this into $this->groups = array_map('strval', (array) $value); and see php/php-src#8825 implemented in PHP 8.2
|
On second though, this is similar to #46363: this is an engine-level consideration that should be fixed either by https://wiki.php.net/rfc/fetch_property_in_const_expressions or https://wiki.php.net/rfc/auto-implement_stringable_for_string_backed_enums |
This PR allow to use Backed enum in constraints groups.