[WebProfilerBundle] Fixes weird spacing in log message context/trace output #45219
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
| @@ -1163,7 +1163,7 @@ table.logs .log-metadata { | ||
| table.logs .log-metadata span { |
There was a problem hiding this comment.
this might need to use > span too, to avoid affecting spans in the nested dump
There was a problem hiding this comment.
Yes indeed, I didn't see any changing behavior before so I left it. But it causes some weird wrapping
the $exists... should start on the same line as the >.
tldr I've added it.
|
Thank you @jennevdmeer. |
This is a fix for a small issue created in bcb3329. Where there is space created in the expanded log message context/trace output as seen below while preserving the space between the log message level, and context and trace toggles.