Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly
Appearance settings

[FrameworkBundle] Fix missing arguments when a serialization default context is bound #45193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Jan 26, 2022
Merged

[FrameworkBundle] Fix missing arguments when a serialization default context is bound #45193

merged 0 commits into from
Jan 26, 2022

Conversation

ArnoudThibaut
Copy link
Contributor

Q A
Branch? 5.4
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #44960
License MIT

I used null as first argument for JsonSerializableNormalizer definition even if a service exist for the ClassMetadataFactoryInterface to keep the actual behavior

@carsonbot carsonbot added this to the 6.1 milestone Jan 26, 2022
@carsonbot
Copy link

Hey!

I see that this is your first PR. That is great! Welcome!

Symfony has a contribution guide which I suggest you to read.

In short:

  • Always add tests
  • Keep backward compatibility (see https://symfony.com/bc).
  • Bug fixes must be submitted against the lowest maintained branch where they apply (see https://symfony.com/releases)
  • Features and deprecations must be submitted against the 6.1 branch.

Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change.

When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor!
If this PR is merged in a lower version branch, it will be merged up to all maintained branches within a few days.

I am going to sit back now and wait for the reviews.

Cheers!

Carsonbot

@ArnoudThibaut ArnoudThibaut changed the base branch from 6.1 to 5.4 January 26, 2022 18:22
@nicolas-grekas
Copy link
Member

/cc @soyuka

chalasr
chalasr approved these changes Jan 26, 2022
View reviewed changes
Copy link
Member

@chalasr chalasr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's the first time the core makes use of bindings I believe, which seems ok.
The fix looks alright 👍

@nicolas-grekas nicolas-grekas modified the milestones: 6.1, 5.4 Jan 26, 2022
@nicolas-grekas
Copy link
Member

Thank you @ArnoudThibaut.

@nicolas-grekas nicolas-grekas merged commit 111459e into symfony:5.4 Jan 26, 2022
This was referenced Jan 28, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas-grekas nicolas-grekas nicolas-grekas approved these changes

@chalasr chalasr chalasr approved these changes

Assignees
No one assigned
Labels
Bug FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
5.4
Development

Successfully merging this pull request may close these issues.

[Serializer] Globally configured serializer context fails
4 participants
@ArnoudThibaut @carsonbot @nicolas-grekas @chalasr
Morty Proxy This is a proxified and sanitized view of the page, visit original site.