[Console] fix restoring stty mode on CTRL+C #45109
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolas-grekas
commented
Jan 21, 2022
| Q | A |
|---|---|
| Branch? | 5.3 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| Tickets | Fix #44045 |
| License | MIT |
| Doc PR | - |
3d9cf4d to
2c9718f
Compare
15a32aa to
2bc6cfc
Compare
|
Hey! I think @ostrolucky has recently worked with this code. Maybe they can help review this? Cheers! Carsonbot |
|
Could this be tested? |
0485358 to
7d40d0b
Compare
|
Test added 🥵 |
7d40d0b to
3dfcbe0
Compare
3dfcbe0 to
b6db5cb
Compare
|
Thank you @nicolas-grekas. |
|
|
remilemonnier
pushed a commit
to remilemonnier/symfony
that referenced
this pull request
Jan 25, 2022
remilemonnier
pushed a commit
to remilemonnier/symfony
that referenced
this pull request
Jan 25, 2022
remilemonnier
pushed a commit
to remilemonnier/symfony
that referenced
this pull request
Jan 25, 2022
remilemonnier
pushed a commit
to remilemonnier/symfony
that referenced
this pull request
Jan 27, 2022
remilemonnier
pushed a commit
to remilemonnier/symfony
that referenced
this pull request
Jan 27, 2022
remilemonnier
pushed a commit
to remilemonnier/symfony
that referenced
this pull request
Jan 27, 2022
Merged
remilemonnier
pushed a commit
to remilemonnier/symfony
that referenced
this pull request
Jan 28, 2022
remilemonnier
pushed a commit
to remilemonnier/symfony
that referenced
this pull request
Feb 1, 2022
remilemonnier
pushed a commit
to remilemonnier/symfony
that referenced
this pull request
Feb 7, 2022
fabpot
added a commit
that referenced
this pull request
Mar 26, 2022
…er (remieuronews) This PR was merged into the 6.1 branch. Discussion ---------- [HttpFoundation] add stale while revalidate cache header | Q | A | ------------- | --- | Branch? | 6.1 | Bug fix? | no | New feature? | yes | Deprecations? | no | Tickets | Feat (#45036) | License | MIT | Doc PR | [symfony/symfony-docs#... <!-- required for new features -->](symfony/symfony-docs#16445) This PR allow support for RFC5861. Meaning you can now use stale_while_revalidate and stale_if_error https://httpwg.org/specs/rfc5861.html Very interesting doc from Fastly on the subject: https://developer.fastly.com/learning/concepts/stale/ Link to the issue #45036 Commits ------- db553fb [cache] #45109 add stale while revalidate and stale if error cache header
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.