Skip to content

Navigation Menu

Sign in
Appearance settings

Search code, repositories, users, issues, pull requests...

Provide feedback

We read every piece of feedback, and take your input very seriously.

Saved searches

Use saved searches to filter your results more quickly

Appearance settings

[Cache] Don't lock when doing nested computations #44820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 28, 2021
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
[Cache] Don't lock when doing nested computations
  • Loading branch information
nicolas-grekas committed Dec 28, 2021
commit be8cbd2aec5c99d901e611945ecfb33e569cb1c9
2 changes: 1 addition & 1 deletion 2 src/Symfony/Component/Cache/LockRegistry.php
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,7 @@ public static function compute(callable $callback, ItemInterface $item, bool &$s

$key = self::$files ? abs(crc32($item->getKey())) % \count(self::$files) : -1;

if ($key < 0 || (self::$lockedFiles[$key] ?? false) || !$lock = self::open($key)) {
if ($key < 0 || self::$lockedFiles || !$lock = self::open($key)) {
return $callback($item, $save);
}

Expand Down
Morty Proxy This is a proxified and sanitized view of the page, visit original site.