[Cache] fix compat with apcu < 5.1.10#44799
Merged
nicolas-grekas merged 1 commit intosymfony:4.4symfony/symfony:4.4from Dec 27, 2021
Merged
[Cache] fix compat with apcu < 5.1.10#44799nicolas-grekas merged 1 commit intosymfony:4.4symfony/symfony:4.4from
nicolas-grekas merged 1 commit intosymfony:4.4symfony/symfony:4.4from
Conversation
ff25e4a to
9cf1260
Compare
StaffNowa
approved these changes
Dec 26, 2021
Contributor
StaffNowa
left a comment
There was a problem hiding this comment.
Good job. Only I have one question about comments inside code :)
| $ids = array_flip($ids); | ||
| foreach (apcu_fetch(array_keys($ids)) ?: [] as $k => $v) { | ||
| if (!isset($ids[$k])) { | ||
| // work around https://github.com/krakjoe/apcu/issues/247 |
Contributor
There was a problem hiding this comment.
SymfonyInsight. Do we need to have here comments?
Member
Author
There was a problem hiding this comment.
I think so yes, I don't want to remove that line again by mistake
HypeMC
reviewed
Dec 27, 2021
9cf1260 to
2d8eeab
Compare
This was referenced Dec 29, 2021
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(Not needed on 6.0)